xpay: emulate maxfeepercent and exemptfee when xpay-handle-pay used #7942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
reviewed
Dec 16, 2024
plugins/xpay/xpay.c
Outdated
| } else | ||
| maxfeepercent_ppm = 500000 / 100; | ||
|
|
||
| if (!amount_msat_fee(&maxfee, amount, 0, maxfeepercent_ppm)) |
There was a problem hiding this comment.
maxfeepercent is a percent in the way this argument is treated by pay and the users of this api expect that.
Suggested change
| if (!amount_msat_fee(&maxfee, amount, 0, maxfeepercent_ppm)) | |
| if (!amount_msat_fee(&maxfee, amount, 0, maxfeepercent_ppm/100)) |
Lagrang3
reviewed
Dec 16, 2024
plugins/xpay/xpay.c
Outdated
| &maxfeepercent_ppm)) | ||
| return false; | ||
| } else | ||
| maxfeepercent_ppm = 500000 / 100; |
There was a problem hiding this comment.
Also here. If this is a percent then 500'000 ppm means 0.5%
Suggested change
| maxfeepercent_ppm = 500000 / 100; | |
| maxfeepercent_ppm = 500000; |
maxfeepercent is use by Zeus, so let's make that work. maxfee is more precise, so it's the only xpay option (maxfee was added to pay later). [ Fix to ppm logic by Lagrang3, thanks! --RR ] Fixes: ElementsProject#7926 Changelog-Changed: JSON-RPC: With `xpay-handle-pay` set, xpay will now be used even if `pay` uses maxfeeprecent or exemptfee parameters (e.g. Zeus) Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
xpay-as-pay-maxfeepercent
branch
from
1369f2c to
49aff81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxfeepercent is use by Zeus, so let's make that work.
maxfee is more precise, so it's the only xpay option (maxfee was added to pay later).
Fixes: #7926
I prefer this to #7936